Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IncorrectValueException that throws if there are definitely no entries for the filter #172

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 28, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

Copy link

what-the-diff bot commented Feb 28, 2024

PR Summary

  • Updated Documentation and Return Type Hints in 'BaseListView.php'
    This PR includes improved documentation and precise return type hints for the makeFilters method in the BaseListView.php file. This improves code readability and helps with error prevention when using this method.

  • Added 'makeFilter' Method and 'IncorrectValueException' Class
    In the FilterableColumnRendererInterface.php and FilterFactoryInterface.php files, a new method makeFilter and a new exception class IncorrectValueException were introduced respectively. The new method enhances flexibility when creating filters, while the introduction of the new exception aids in handling inaccuracies more effectively.

  • New Error Handling for 'makeFilter' Call in 'GridView.php'
    We have improved the error handling mechanism in GridView.php when calling the makeFilter method of FilterableColumnRendererInterface. This will enable more efficient troubleshooting, providing clearer and more specific error messages when using this functionality.

@vjik vjik requested a review from a team February 28, 2024 07:36
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 65.49%. Comparing base (f7f4086) to head (46da9b5).

Files Patch % Lines
src/GridView.php 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #172      +/-   ##
============================================
- Coverage     65.60%   65.49%   -0.11%     
- Complexity      541      543       +2     
============================================
  Files            46       46              
  Lines          1817     1820       +3     
============================================
  Hits           1192     1192              
- Misses          625      628       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik added the status:code review The pull request needs review. label Feb 28, 2024
@vjik vjik merged commit 833901b into master Mar 2, 2024
16 of 18 checks passed
@vjik vjik deleted the no-filter branch March 2, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants